Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes data #41

Open
danieljuschus opened this issue Dec 19, 2021 · 5 comments
Open

Shapes data #41

danieljuschus opened this issue Dec 19, 2021 · 5 comments

Comments

@danieljuschus
Copy link

I noticed that the function atoc2gtfs generates an error ("Shapes are not yet supported") if shapes = True. Has this just not been implemented yet, or does the data from atoc.org not include shape information at all? I tried to take a quick look at their manual, but I couldnt't figure it out.

@mem48
Copy link
Contributor

mem48 commented Dec 22, 2021

The feature hasn't been properly implemented. The ATOC data does not include the necessary information so I'd started implementing my own solution but it was very time consuming.

There is some old code https://github.com/ITSLeeds/UK2GTFS/blob/2a376bc88e4dfa3f1f0f331139c1685dfff0dbe4/R/atoc_shapes.R if your intrested

@danieljuschus
Copy link
Author

Alright! I've tried to use this: https://github.com/ad-freiburg/pfaedle but it didn't work with the output from UK2GTFS. The problem is that there are some stop_id values in stop_times.txt which don't appear in stops.txt. Is that a know problem?

@mem48
Copy link
Contributor

mem48 commented Jan 15, 2022

Thanks for this, I have a look and see if I can get it working with UK2GTFS

@mem48 mem48 reopened this Jan 15, 2022
@stupidpupil
Copy link
Contributor

I'm not doing anything clever and it's very messily put together, but I'm now using pfaedle in my Wales-centric processing.

(I note that I do filter out some inconsistencies as part of chopping outputs down to a particular space and time, and then I put the GTFS files through gtfstidy before pfaedle.)

@mem48
Copy link
Contributor

mem48 commented Jul 17, 2023

@stupidpupil & @danieljuschus FYI I've now added support for this as a separate function https://itsleeds.github.io/UK2GTFS/reference/ATOC_shapes.html Needs mor testing before rolling into the main function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants