Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more #c: tags #361

Open
ardissaps opened this issue Aug 2, 2022 · 6 comments
Open

Add more #c: tags #361

ardissaps opened this issue Aug 2, 2022 · 6 comments
Labels
confirmed This enhancement will be added. enhancement New feature or request

Comments

@ardissaps
Copy link

On fabric, most used tag is c: so the ingredient can be used in other mods, it is easy for me to fix myself with KubeJS but it would be better if it is fixed on official build.

@itsmeow
Copy link
Owner

itsmeow commented Aug 2, 2022

Hi, we use c as well as forge tags. It's easier to just include both on both platforms.

@itsmeow
Copy link
Owner

itsmeow commented Aug 2, 2022

@ardissaps
Copy link
Author

Is it, mine does not have c: tag, I am on 1.18.2.

@itsmeow
Copy link
Owner

itsmeow commented Aug 2, 2022

As you can see on the link there are a bunch of c tags. So they should be there.

Here's the 1.18 branch
https://github.com/itsmeow/betteranimalsplus/tree/1.18/common/src/main/resources/data/c/tags/items

@ardissaps
Copy link
Author

ardissaps commented Aug 2, 2022

I see, sorry! Maybe add another tag like for eel to use "#c:raw_fish" etc, or is it intended that eel is not fish?

Edit : I also found that it is on Farmers Delight (someone already post it actually) that should fix it, they use "#fabric:xxx" tag instead which should be "#c:" that is more common on Fabric ecosystem, sorry for your time! Thank you for the great mods. : )

@itsmeow
Copy link
Owner

itsmeow commented Aug 30, 2022

I had limited examples of mods using #c tags when I made the original tags, I can add more.

@itsmeow itsmeow added enhancement New feature or request confirmed This enhancement will be added. labels Dec 21, 2022
@itsmeow itsmeow changed the title Please remove all #forge: tag from Fabric version of the mod and use #c: instead. Add more #c: tags Jan 11, 2023
@itsmeow itsmeow moved this to Misc Improvements in Better Animals Plus TODO Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This enhancement will be added. enhancement New feature or request
Projects
Status: Misc Improvements
Development

No branches or pull requests

2 participants