Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Release rc-2020-06-09 "Hogfather". #16

Open
paianoa opened this issue Jun 30, 2020 · 5 comments
Open

Problems with Release rc-2020-06-09 "Hogfather". #16

paianoa opened this issue Jun 30, 2020 · 5 comments

Comments

@paianoa
Copy link

paianoa commented Jun 30, 2020

After upgrading dokuwiki doesn't start.

Checking apache error log I see:

PHP Fatal error: Declaration of action_plugin_authshibboleth::register() must be compatible with dokuwiki\Extension\ActionPlugin::register(Doku_Event_Handler $controller) in /var/www/lib/plugins/authshibboleth/action.php on line 0,

PHP 5.6.31-1~dotdeb+7.1
apache 2.2

@paianoa
Copy link
Author

paianoa commented Jul 1, 2020

Today I also tried to:

  • setup a fresh Dokuwiki installation on a Debian10 (package got from debian official repo)
  • Upgraded to rc-2020-06-09 "Hogfather"
  • Installed Plugin

The plugin doesn't even appear in the list when trying to configure the Authentication backend (from web ui)

@ivan-novakov
Copy link
Owner

I guess the plugin is already too old :). Do you feel like sending a fix in a PR? I haven't been using DokuWiki for years now...

@vecdan
Copy link

vecdan commented Aug 27, 2020

The fix is easy. Just change in the file action.php line:
public function register(Doku_Event_Handler &$controller)

to

public function register(Doku_Event_Handler $controller)

kosli added a commit to kosli/dokuwiki-shibboleth-auth that referenced this issue Nov 26, 2020
This was referenced Nov 26, 2020
@kosli
Copy link
Contributor

kosli commented Feb 24, 2021

@ivan-novakov are you going to merge the pull request? for me it works fine.

@coudot
Copy link

coudot commented Jun 2, 2022

The pull request as merged, thanks @ivan-novakov

I think this issue can be closed.

@ivan-novakov do you plan to publish a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants