Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module name colliding with other packages #12

Open
alexisrolland opened this issue Oct 5, 2018 · 3 comments
Open

Module name colliding with other packages #12

alexisrolland opened this issue Oct 5, 2018 · 3 comments

Comments

@alexisrolland
Copy link

The module name graphql when doing the import is very generic and collides with other packages I'm using. If you plan some evolutions in the future, I would suggest to change it to something more specific such as graphqlparser or similar...

Thanks for this good package!

@stebunovd
Copy link
Member

hey Alexis,

could you please clarify, with which exactly other packages does it collide? From what I see it doesn't collide with anything from here https://graphql.org/code/#python-1

thanks,

Denis

@alexisrolland
Copy link
Author

alexisrolland commented Oct 7, 2018

Hi Denis,
I was under the impression your package name collides with https://graphene-python.org because after installing graphene I can do import graphql and after installing graphql-py I can also do import graphql. Can you please help me to understand what happens in the background? Are both packages using a shared graphql folder / package?

Thanks

@stebunovd
Copy link
Member

yeah, it turns out graphene depends on graphql-core, which introduces graphql package. Ok, thanks for the note. I'll consider renaming in future releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants