Fix deps and buffer #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes warning: `(node:3640) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.`
|
Travis builds for Node version >= 6 pass. Other lower versions fail. I suggest a major release that drops support for these older versions (below v6). This removes vulnerabilities and fixes deprecated code use. IMO, this is critical for an SDK that handles sensitive operations such as credit-card payments. You can still provide iyzipay-node v2.0.34 release for users needing support for old Node versions. |
|
This seems really important. Are there Iyzico devs alive to merge this PR? It's really disappointing for a payment service to leave these security issues unadressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request(production) dependency to latest version. Fixes Update request dependency #62new Buffer()warning. Fixes Use Buffer.from() instead of new Buffer() #63package-lock.json