Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support integer passthrough when hashing strings for dsjson and vwtest #41

Open
jackgerrits opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement New feature or request vw-compat Issues relating the compatibility with the Vowpal Wabbit library

Comments

@jackgerrits
Copy link
Owner

jackgerrits commented Jul 10, 2023

Users of these two formats expect to be able to (via a config option) treats strings which are just integers as the integers themselves when they are "hashed", rather than being actually hashed.

This should be able to be configured, so the question is is this runtime config or model config? I am pretty confident it is runtime config. Additionally, since it does not apply to all parsers the question of parser specific configuration comes up too.

In the new Json format the proposal for the same behavior could be to extend the usage of the : special char and make any number prepended with a : to be treated as the number itself and not hashed.

@jackgerrits jackgerrits added enhancement New feature or request vw-compat Issues relating the compatibility with the Vowpal Wabbit library labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vw-compat Issues relating the compatibility with the Vowpal Wabbit library
Projects
None yet
Development

No branches or pull requests

1 participant