Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Serializer not compatible with Bolt plugin #152

Open
edwonedwon opened this issue Jan 9, 2018 · 4 comments
Open

Full Serializer not compatible with Bolt plugin #152

edwonedwon opened this issue Jan 9, 2018 · 4 comments

Comments

@edwonedwon
Copy link

Full serializer overrides the default Unity serializer in apparently all cases, including the Bolt visual scripting plugin I was using. This was causing MAJOR performance slowdowns in the unity editor.

You guys might want to put a strong warning to devs not to mix and match full serializer with any plugin project wide that uses serialization in any way.

There should also be a way to disable full serializer on a per script bases.

@SugoiDev
Copy link
Collaborator

SugoiDev commented Jan 9, 2018

Could you elaborate on how you're using FullSerializer?
FullSerializer should be serializing only what you explicitly tell it to.

To ignore an entire type, use the fsObject attribute with the MemberSerialization.OptOut option. This will tell FI not to serialize anything in the type, unless you use the fsProperty attribute.

@edwonedwon
Copy link
Author

We were using it to help with serialization of our game data. We found fs useful because it could handle inheritance and lists of scriptable objects much better than the built in unity json serializer.

However due to the bolt conflict, and us not even having save data in our game anymore, we deleted fs from our project and things sped up considerably.

We found out recently that Bolt actually uses fs already (or at least a modified version of it) but I think it might be hidden away in a dll somewhere.

@SugoiDev
Copy link
Collaborator

@lazlo-bonin do you know of any incompatibility when using fullserializer alongside with Bolt?
Since everything is namespaced I'm failing to find a reason why it would break, but I don't own Bolt so I can't test this right now.

@edwonedwon
Copy link
Author

P.S. I cannot conclusively proove that it was the fault of having FS in our project, but I just know when I deleted it I had no more massive editor slowdowns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants