Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about loop edge, curved edge, quadratic edge #1407

Closed
nesimii opened this issue Mar 14, 2024 · 3 comments
Closed

about loop edge, curved edge, quadratic edge #1407

nesimii opened this issue Mar 14, 2024 · 3 comments

Comments

@nesimii
Copy link

nesimii commented Mar 14, 2024

Greetings to the Sigma js team,

I was using the curved edge codes I found sample code another repo on Github, but it was not working properly.
I saw that you added curved edge in v3 version, thank you.
I offer two feature suggestions from you;

  1. Can you add quadratic bezier edge arrow?

  2. Is it possible to add loop edge in addition? In the system I use, there can be more than one loop edge on a node.

images

@jacomyal
Copy link
Owner

The new @sigma/edge-curve is supposed to draw quadratic Bézier curves. Can you precise how it is not working properly please?

Also, about the other questions:

  1. For the arrow, the hardest part is to "stop" the curve "before" the target node. It is possible, but not a priority right now.
  2. Self loops should indeed come at some point. I'll leave this ticket open for this very feature for now.

@nesimii
Copy link
Author

nesimii commented Mar 22, 2024

I guess I didn't explain it properly.
I am using 'sigma v2.4.0' version, I haven't used 'v3' version because it is in beta.
I found sample code on github for curved edges. so the sample code is not working properly.

There is a sample code for loop edges, if you want to examine it;
SpecterOps/BloodHound@47bdcba#diff-2e356fea35ac46e0612aab930e14483eeacbd3b08248035ea167e5cd76198962

@jacomyal
Copy link
Owner

I close this ticket since the only missing feature is the self-loop, and ticket #1429 will be the reference for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants