[layer-maplibre, layer-leaflet] fix issues on clean-up #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix : - multiple calls to the clean function leads to an error - clean function doesn't reset the sigma settings to the previous one
sim51
force-pushed
the
bsi/map-layer-fixes
branch
from
4930a32 to
cbb54fb
Compare
jacomyal
added a commit
that referenced
this pull request
Oct 29, 2024
Details: - Moves layers/leaflet.ts to layer-leaflet/lifecycle.ts - Moves layers/maplibre.ts to layer-maplibre/lifecycle.ts - Fixes weird "stderr" from MapLibre tests, by overriding the map's style - Fixes overriding map style when calling bindMapLayer for MapLibre - Removes unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix :