Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results "as loaded" ordering #933

Open
10 tasks done
PureTryOut opened this issue Nov 16, 2023 · 6 comments · May be fixed by #976
Open
10 tasks done

Search results "as loaded" ordering #933

PureTryOut opened this issue Nov 16, 2023 · 6 comments · May be fixed by #976
Labels

Comments

@PureTryOut
Copy link
Contributor

Iris version

3.69.0

Operating system(s) affected

  • Windows
  • MacOS
  • iOS
  • Android
  • Linux
  • Other

Browser(s) affected

  • Firefox
  • Chrome
  • Edge
  • Other

What happened?

When searching for any track on the Spotify source, it's search results are very inaccurate. When you search for any particular term, the first 10 or so results are often completely unrelated and don't even have you search term in either the track, artist or album name. End result is that I often can't find the track I'm looking for even though the exact same query directly on the Spotify client does give me the track I'm looking for as the very first result.

I know Iris searches on Spotify directly rather than going through Mopidy which is why I'm posting this here.

Logs

No response

@PureTryOut PureTryOut added the bug label Nov 16, 2023
@jaedb
Copy link
Owner

jaedb commented Nov 16, 2023

Can you please provide some examples of the search query you're using, and the resulting Spotify search results? An output of your browser HTTP requests would also be really helpful to confirm the actual HTTP requests sent to the Spotify API.

For example:
image

@PureTryOut
Copy link
Contributor Author

Ok for example, searching for the track "Infinity" from the artists "Sefa" and "D-Block & S-te-Fan" (query being sefa infinity).

The Spotify client has the track I want as the very first result.
On Iris it is the... (/me counts) 27th result.

Following screenshots are in order from top to bottom (I had to scroll the page quite a bit):

Screenshot 2023-11-17 at 09-11-05 Search sefa infinity
Screenshot 2023-11-17 at 09-11-28 Search sefa infinity
Screenshot 2023-11-17 at 09-12-00 Search sefa infinity

Browser requests for that query:
Screenshot_20231117_091355

@PureTryOut
Copy link
Contributor Author

So I'm looking into the response to the actual Spotify request. The result in Iris makes no sense to me compared to what Spotify gives me. The right search result is present as the very first item in the list of albums, artists and tracks. I'm assuming the album, artist and playlist results are used for the segments at the top of the page so I'm ignoring that.

If the right track is the very first result in the list of tracks, why does Iris then show it way down in the list?

Screenshot_20231206_101208

@jaedb jaedb changed the title Spotify search results are very inaccurate Search results "as loaded" ordering Jan 13, 2024
@jaedb
Copy link
Owner

jaedb commented Jan 13, 2024

The issue isn't so much that results are inaccurate, rather the order is not the same as in the Spotify client. That the Spotify API returns results the same as the Spotify Client is helpful.

The solution here (as I see it; open to other suggestions!) is to add a new sorting option for search results: "As loaded". This is the same as in other views (Library -> Playlists for instance) and does not apply any sorting of results, meaning that they're displayed however they are returned from their respective sources.

Note that this will mean results are bundled together (ie all Spotify results and then Local results) but the order of each bundle will be unpredictable.

@mczerski
Copy link

Starting from Iris version 3.67.0 spotify search results are totally different than for previous versions and my wife is very dissapointed with that :( so I kindly ask if we can go back to previous search algorithm, cause I need to stay on version 3.66.1 if I want to get laid :-D

@PureTryOut
Copy link
Contributor Author

PureTryOut commented May 20, 2024

The issue isn't so much that results are inaccurate, rather the order is not the same as in the Spotify client.

Actually, to the end user this is "inaccurate". You just get completely unrelated results first. It's fine if those were way down the list, but they're not. Instead they're represented as "the best match for your query" which they're (obviously) not by a long shot.
"As loaded" as an additional option would be nice but honestly, this ordering shouldn't even be a thing in the first place.

What exactly is the current ordering? Does it for some reason show the results ordered exactly the opposite of what one would expect? Does it somehow smash together multiple sources inaccurately? I just don't know what I'm looking at 🤔

EDIT: actually I figured it out, the ordering is alphabetical. That makes in my opinion no sense for search results...

@antonnyst antonnyst linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants