Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@jakarta.faces.annotation.View#value must be @Nonbinding #1865

Closed
BalusC opened this issue Nov 26, 2023 · 2 comments
Closed

@jakarta.faces.annotation.View#value must be @Nonbinding #1865

BalusC opened this issue Nov 26, 2023 · 2 comments
Labels
rejected

Comments

@BalusC
Copy link
Member

BalusC commented Nov 26, 2023 •
edited
Loading

Discovered during eclipse-ee4j/mojarra#5362

The @jakarta.faces.annotation.View#value must be @Nonbinding.
@BalusC BalusC added this to the 4.1 milestone Nov 26, 2023
@BalusC BalusC mentioned this issue Nov 26, 2023
Closed
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Nov 26, 2023
@BalusC
@jakarta.faces.annotation.View#value must be @Nonbinding
f268d46 
jakartaee/faces#1865
#5367
@BalusC BalusC mentioned this issue Nov 26, 2023
Merged
@BalusC BalusC added the mojarra-implemented API issue implemented by Mojarra label Nov 26, 2023
@volosied
Copy link
Contributor

volosied commented Nov 29, 2023 •
edited
Loading

Commented in the Mojarra repo by accident. See my post there: eclipse-ee4j/mojarra#5368 (comment)

The /hello-facelet mapping works, but /hello-facelet.xhtml fails due to ambiguous beans.

Should we make this Nonbinding? The Any Literal Annotation may enough for 4.1 & 5.0 to avoid regressions.

@BalusC BalusC added rejected and removed mojarra-implemented API issue implemented by Mojarra labels Nov 30, 2023
@BalusC BalusC removed this from the 4.1 milestone Nov 30, 2023
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Nov 30, 2023
@BalusC
Revert "@jakarta.faces.annotation.View#value must be @Nonbinding jaka…
12ca56e 
…rtaee/faces#1865 #5367"

This reverts commit f268d46.
@BalusC
Copy link
Member Author

BalusC commented Nov 30, 2023

Reverted: eclipse-ee4j/mojarra@12ca56e

@BalusC BalusC closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rejected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BalusC @volosied