Multipart performs blocking call in every instantiation #699 #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jmehrens
requested changes
Mar 6, 2024
|
@jmehrens I am redesigning it, because I found more usages of |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jmehrens
requested changes
Mar 7, 2024
|
Need to add entry to https://github.com/jakartaee/mail-api/blob/master/doc/release/CHANGES.txt |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Done |
|
Lets wait for @lukasj review too. My impression is this requires the new version 2.2.0, and we will need other PR before to upgrade to that version. |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jmehrens
requested changes
Mar 8, 2024
jmehrens
requested changes
Mar 8, 2024
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jmehrens
approved these changes
Mar 8, 2024
|
Side note: we'll have to review some of the Angus packages that also extend the classes here. DSN is an example. I glossed over it and I think it is a case of no changes need but something we should keep an eye on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#699
It will try to get the StreamProvider from the session of the Message.