Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We seemed to have lost @SetupMethod usage on some tests #1699

Open
starksm64 opened this issue Dec 10, 2024 · 0 comments
Open

We seemed to have lost @SetupMethod usage on some tests #1699

starksm64 opened this issue Dec 10, 2024 · 0 comments

Comments

@starksm64
Copy link
Contributor

Describe the bug
The ee.jakarta.tck.persistence.core.query.flushmode.* tests are failing because there don't appear to be any test entities to query. Looking at ee.jakarta.tck.persistence.core.query.flushmode.Client2#flushModeTest2:

		public void flushModeTest2() throws Exception {
		boolean pass = false;
		String expectedPKs[];

vs the com.sun.ts.tests.jpa.core.query.flushmode.Client#flushModeTest2 test in EE10:

  @SetupMethod(name = "setupOrderData")
  public void flushModeTest2() throws Fault {
    boolean pass = false;
    String expectedPKs[];
...

the EE11 test is missing the @SetupMethod(name = "setupOrderData") which should trigger a call to the superclass setupOrderData to create the test entities.

Th SetupMethod annotation is used in these EE10 test packages:

com.sun.ts.tests.jpa.core.criteriaapi.CriteriaBuilder
com.sun.ts.tests.jpa.core.criteriaapi.CriteriaQuery
com.sun.ts.tests.jpa.core.criteriaapi.From
com.sun.ts.tests.jpa.core.criteriaapi.metamodelquery
com.sun.ts.tests.jpa.core.criteriaapi.misc
com.sun.ts.tests.jpa.core.criteriaapi.Root
com.sun.ts.tests.jpa.core.criteriaapi.strquery
com.sun.ts.tests.jpa.core.query.flushmode
com.sun.ts.tests.jpa.core.query.language

We need to add the correct SetupMethod annotation to the equivalent packages in EE11.

starksm64 added a commit that referenced this issue Dec 11, 2024
Signed-off-by: Scott M Stark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant