Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal price handling uses JS floating-point #4

Open
james-camilleri opened this issue Sep 10, 2023 · 0 comments
Open

Internal price handling uses JS floating-point #4

james-camilleri opened this issue Sep 10, 2023 · 0 comments
Assignees
@james-camilleri
Labels
critical Severely impacting the functionality of the system enhancement New feature or request size: medium 1–4 hours, an evening's work

Comments

@james-camilleri
Copy link
Owner

This is bad. We're bound to have rounding errors at some point, and Stripe expects everything in integer values anyway so we might as well do the smart thing and use integers internally.
@james-camilleri james-camilleri self-assigned this Oct 18, 2023
@james-camilleri james-camilleri added enhancement New feature or request critical Severely impacting the functionality of the system size: medium 1–4 hours, an evening's work labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james-camilleri james-camilleri

Labels
critical Severely impacting the functionality of the system enhancement New feature or request size: medium 1–4 hours, an evening's work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@james-camilleri