Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Enhance error page #8

Open
jangerhard opened this issue May 1, 2018 · 1 comment
Open

Feature - Enhance error page #8

jangerhard opened this issue May 1, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jangerhard
Copy link
Owner

jangerhard commented May 1, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
Make sure the component shows a nice-looking message if the component crashes by a 401.

Describe the solution you'd like
Display information stating that the API-key is expired/invalid.

The file "ErrorComponent.js" currently shows an error message in plaintext, but the look is really ugly. Anything else is preferred! Preferably with a picture indicating something went wrong.

Test plan

We need snapshot testing and unit testing!
@jangerhard jangerhard added the enhancement New feature or request label May 1, 2018
@jangerhard jangerhard changed the title Error handling Feature - Error handling May 8, 2018
jangerhard added a commit that referenced this issue May 8, 2018
@jangerhard
#8 - Initial test added for GetStatsService
ff60892
@jangerhard jangerhard mentioned this issue May 10, 2018
Closed
@jangerhard jangerhard changed the title Feature - Error handling Feature - Show message for 401 Unauthorized May 25, 2018
@jangerhard jangerhard added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2018
@jangerhard jangerhard changed the title Feature - Show message for 401 Unauthorized Feature - Enhance error page Aug 10, 2018
@jangerhard
Copy link
Owner Author

Work has started in PR #24 and we would greatly appreciate all the help we can get!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jangerhard