Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding general rules to e2e contribution guidelines #1966

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 20, 2024

Description

Adding some general rules that I think are relevant.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@nilgaar nilgaar requested a review from a team as a code owner November 20, 2024 21:47
@nilgaar nilgaar changed the title adding general rules docs(e2e): adding general rules to e2e contribution Nov 20, 2024
@nilgaar nilgaar changed the title docs(e2e): adding general rules to e2e contribution docs(e2e): adding general rules to e2e contribution guidelines Nov 20, 2024
@nilgaar nilgaar changed the title docs(e2e): adding general rules to e2e contribution guidelines docs: adding general rules to e2e contribution guidelines Nov 20, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

@subhashkhileri
Copy link
Member

/ok-to-test

@subhashkhileri
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 22, 2024
Copy link
Member

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [josephca,subhashkhileri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants