Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamically update query parameters on currency changes #1

Open
japherwocky opened this issue Mar 21, 2017 · 0 comments
Open

dynamically update query parameters on currency changes #1

japherwocky opened this issue Mar 21, 2017 · 0 comments

Comments

@japherwocky
Copy link
Owner

In 46dc972 we added support for GET params, a la ?currency=USD

This will set the currency, but this can then be overridden by selectors on the page. It would be nice to change the GET param in the URL.

Maybe it's easier to just set the param whenever the currency changes?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@japherwocky