Feat: Support custom playback speed #895
Open
+130
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b85fc34.
chore(translate): (Portuguese (Brazil))
…aces that swap uses for '.' and ',' compared to English representation.
…ttributes consistently.
… slider precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #889 by adding a second dialog with a SeekBar to choose a custom playback speed in the range 0.25x - 4x
Also adds localization to existing playback speed labels to support locations that use
,to delimit decimals and.to delimit 1000s.E.g. In Italian:
Notes
I've implemented this programmatically rather than using a declarative layout but tips/contributions for creating the dialog declaratively are appreciated.