Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path with spaces gets broken up at space #439

Open
patrikhuber opened this issue Sep 30, 2024 · 4 comments
Open

Path with spaces gets broken up at space #439

patrikhuber opened this issue Sep 30, 2024 · 4 comments

Comments

@patrikhuber
Copy link

Hi,

I've got a simple app with an --input argument that contains a path with a space. I'm using VS and launch.vs.json to launch this, so the args part of launch.vs.json looks like:

      "args": [
        "--input",
        "\"C:\\My - Long path\""
      ]

And I'm reading this into cxxopts with input_path = result["input"].as<std::filesystem::path>();.

The problem is that input_path only contains C:\\My.

I've tried it with and without the escaped quotes in launch.vs.json (i.e. with and without the extra \" but it didn't make any change.
I can also confirm that argv[2] does confirm the whole path, i.e. argv[2] is a char* containing "C:\\My - Long path".

Seems cxxopts is parsing / breaking this up wrongly?

@jarro2783
Copy link
Owner

I suspect that because you have used std::filesystem::path it is getting put through the stringstream parser which is splitting it at the first space. If you make it a string then it should work. It should probably just work though, I'll see if I can work out a proper fix.

@patrikhuber
Copy link
Author

Thanks @jarro2783. Any chance to get a fix in for this? std::filesystem::path is pretty commonly used these days.

patrikhuber added a commit to patrikhuber/eos that referenced this issue Dec 15, 2024
We set the cxxopts type to std::string, and then read it into a filesystem::path. Due to jarro2783/cxxopts#439 we don't use filesystem::path with cxxopts directly.
Like this, we can read paths with spaces using "\...path with space\" in launch.vs.json, and paths without spaces without the extra quotes.
@jarro2783
Copy link
Owner

Not yet, I'll try and get some time this week.

@nigels-com
Copy link
Contributor

@patrikhuber I had a go at supporting this, can you give that branch a try for your use case? PR #447
Would appreciate any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants