New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in _sample_orthonormal_to #33

Open

saurabhsharma1993 opened this issue Mar 30, 2021 · 0 comments

saurabhsharma1993 commented Mar 30, 2021

In line 55 in spherecluster/util.py, in the _sample_orthonormal_to function, it reads:

proj_mu_v = mu * np.dot(mu, v) / np.linalg.norm(mu)

Shouldn't it instead be:

proj_mu_v = mu * np.dot(mu, v) / np.linalg.norm(mu)**2

If norm(mu)=1 then it doesn't make a difference, but otherwise they are quite different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment