Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better cleanup when aborting a build / test run #15

Open
jasonmccampbell opened this issue Apr 27, 2021 · 0 comments · May be fixed by #14
Open

Need better cleanup when aborting a build / test run #15

jasonmccampbell opened this issue Apr 27, 2021 · 0 comments · May be fixed by #14

Comments

@jasonmccampbell
Copy link
Owner

Biggest issue: server leaves .spraycc-history file laying around when cancelled. If done in a subdirectory this can cause a run from the top-level to fail when clients start in the subdirectory and attempt to connect to the wrong server.

Second issue: ctrl-C of make terminates the clients, which disconnect from the server, but don't stop any of the jobs. If the server has 1k jobs, it will continue feeding the execs for no reason. If the server is terminated, see above.

Third issue: even if the server is terminated, the executors continue running the tasks to completion before exiting. This may or may not be a long time. This is because tasks are run synchronously instead of asynchronous so the disconnect goes unnoticed.

In general, should ctrl-c of one client cause that one task to be removed? Is it work the bookkeeping to do that? Or is the general case all clients are terminated, at which point the server can go into shutdown mode?

@jasonmccampbell jasonmccampbell linked a pull request Apr 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant