Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling X-Audit-Log-Reason Header #46

Open
nateweisz opened this issue Apr 11, 2024 · 3 comments
Open

Handling X-Audit-Log-Reason Header #46

nateweisz opened this issue Apr 11, 2024 · 3 comments

Comments

@nateweisz
Copy link
Contributor

Description of the Issue

We should either provide an interface like Auditable that has a function like withAuditLogReason or something like that. This should be decided one when the higher level api is implemented.

@surajkumar
Copy link
Contributor

Related PR: #42

@surajkumar
Copy link
Contributor

surajkumar commented Jun 1, 2024

Possibly, we can add it as another optional field to the DiscordRequest objects and provide the value using the RequestBuilder classes that we have. We should create a list of all the endpoints that use the X-Audit-Log-Reason header.

@nateweisz
Copy link
Contributor Author

Possibly, we can add it as another optional field to the DiscordRequest objects and provide the value using the RequestBuilder classes that we have. We should create a list of all the endpoints that use the X-Audit-Log-Reason header.

Hi, haven't been active on this project recently since I've been pretty busy but I've got an idea. We can make an IAuditable or something and just check if the request is an instance of it, unless that would be hard to implement into the builder's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants