Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Warning: Parameter 1 to DiscordHooks::onArticleRevisionVisibilitySet() expected to be a reference, value given" #52

Open
Dinoguy1000 opened this issue Jun 27, 2023 · 0 comments

Comments

@Dinoguy1000
Copy link
Contributor

This error is produced on changing the visibility of a revision (specifically on changing the visibility of the revision text, though I'm sure it would happen on changing the visibility of the summary or actor name, or any combination of them). Comparing the parameters of onArticleRevisionVisibilitySet() to other functions, the former uses &$title while e.g. onArticleUndelete() instead uses Title $title (but looking at more functions suggests there's no real set pattern to what exactly is passed in for the page title of the action performed, I'm guessing because the hooks used just aren't consistent either?)

Note that this was encountered on MW 1.31, so changes in subsequent versions of MW may have fixed this (the parameter references are identical between the REL1_31 and main branches of this extension).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant