Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% coverage #16

Open
jayvdb opened this issue Feb 26, 2020 · 1 comment
Open

100% coverage #16

jayvdb opened this issue Feb 26, 2020 · 1 comment
Labels
tests

Comments

@jayvdb
Copy link
Owner

jayvdb commented Feb 26, 2020

There are already some # pragma: no cover in the code, and a few more will be enough to reach 100% so it can be enforced
jayvdb added a commit that referenced this issue Feb 27, 2020
@jayvdb
tox.ini: Default to fail coverage under 95%
6740fb1 
Allow 65% coverage only on Python 3.4 where lxml is not
being installed.

Related to #16
jayvdb added a commit that referenced this issue Feb 27, 2020
@jayvdb
tox.ini: Default to fail coverage under 95%
cd53ded 
Allow 65% coverage only on Python 3.4 where lxml is not
being installed.

Related to #16
jayvdb added a commit that referenced this issue Feb 27, 2020
@jayvdb
tox.ini: Default to fail coverage under 95%
e8a7921 
Allow 65% coverage only on Python 3.4 where lxml is not
being installed.

Increase maxfail so that one website cant easily stop the CI.

Related to #16
@jayvdb
Copy link
Owner Author

jayvdb commented Feb 27, 2020

coverage is now locked in 95% - this issue is now a low priority.

@jayvdb jayvdb added the tests label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb