Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in test_adapter #25

Open
jayvdb opened this issue Feb 27, 2020 · 0 comments
Open

Reduce duplication in test_adapter #25

jayvdb opened this issue Feb 27, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.2.3

Comments

@jayvdb
Copy link
Owner

jayvdb commented Feb 27, 2020

It isnt clear how each adapter functions differently from the others.

TestCase inheritance was used for the everywhere adapters.

It should also be added to the non-everywhere adapters to reduce duplication of identical behaviour.
@jayvdb jayvdb added bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 27, 2020
@jayvdb jayvdb added this to the v0.2.3 milestone Apr 21, 2020
jayvdb added a commit that referenced this issue Apr 21, 2020
@jayvdb
test_upstream: Create
80e4f44 
Tests purely of requests HTTPAdapter, which can be used to prepare
offline tests, and base all other tests on to show where other
adapters differ from pure requests.

Related to #14
Related to #25
jayvdb added a commit that referenced this issue Apr 21, 2020
@jayvdb
test_adapter: Remove TestUpgradeAdapter
ea34315 
Removing this in a separate commit radically improves the
readability of the next commit.

Related to #25
jayvdb added a commit that referenced this issue Apr 21, 2020
@jayvdb
test_adapter: Use inheritance
06ec552 
Reduce duplication of expected results, and better show
which adapters are most similar, and the remaining tests
better demonstrate how they are different.

Improved some tests to be more specific.

Also add tests for wiki.ros.org.

Closes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.2.3
Development

No branches or pull requests
1 participant
@jayvdb