-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
632 Delete Requests #637
base: master
Are you sure you want to change the base?
632 Delete Requests #637
Conversation
ashfaq1934
commented
Jan 1, 2023
- Adds a button to each request card and detail page which allows you to delete individual request without having to click clear db.
- Resolves Allow to delete some requests #632
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 86.42% 86.88% +0.45%
==========================================
Files 52 52
Lines 2078 2189 +111
==========================================
+ Hits 1796 1902 +106
- Misses 282 287 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dd3d71e
to
b10d04a
Compare
b10d04a
to
e919cdd
Compare
|
||
def test_delete(self): | ||
response = self.client.post(reverse('silk:request_detail', kwargs={'request_id': str(self.request.id)})) | ||
self.assertEqual(response.status_code, HTTPStatus.FOUND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests! A few nitpicks:
- Can you make sure that this re-routes to the summary page and the object is deleted. (Bonus for test that checks the redirection for header Referer)
- Another test that checks when we pass in a non-existing request