Fix double EXPLAIN when calling explain on queryset #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 86.51% 86.48% -0.03%
==========================================
Files 52 52
Lines 2091 2094 +3
==========================================
+ Hits 1809 1811 +2
- Misses 282 283 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stereodamage
force-pushed
the
fix-explain
branch
2 times, most recently
from
10e8b7b
to
2485450
Compare
stereodamage
force-pushed
the
fix-explain
branch
from
2485450
to
e5f77ca
Compare
for more information, see https://pre-commit.ci
|
Hey, I just encountered this issue too. I think the changes look good but test coverage is failing. I can help you add some unit tests if you'd like @stereodamage. |
pawelzar
reviewed
Feb 25, 2024
| @@ -53,7 +54,11 @@ def _explain_query(connection, q, params): | |||
|
|
|||
| # currently we cannot use explain() method | |||
| # for queries other than `select` | |||
| prefixed_query = f"{prefix} {q}" | |||
| if re.match(f"^{prefix} .*", q): | |||
There was a problem hiding this comment.
What do you think about using just str.startswith() instead?
Suggested change
| if re.match(f"^{prefix} .*", q): | |
| if q.startswith(prefix): |
|
@pawelzar that would be nice of you, I appreciate that. Didn't really had much time to look into it again and write new test myself. Anything needed from my side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #597, #650.
There's also an idea to wrap call to database into
try..exceptand throw something likeProgrammingError(according to PEP 249) or custom error based on ProgrammingError.