Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove possibleResponse #24

Open
naturallymitchell opened this issue Oct 15, 2018 · 3 comments
Open

remove possibleResponse #24

naturallymitchell opened this issue Oct 15, 2018 · 3 comments

Comments

@naturallymitchell
Copy link
Member

https://github.com/foundpatterns/lighttouch-libs/blob/7eb07b2262d7cf37db1be123989e6f282b762969/package_loader.lua#L237

what is the logical flow from and then onward with possibleResponse?

can we also name it possibe_outgoing_response?

@aleksanderwlodarczyk
Copy link
Contributor

Long time ago we were getting proper response from one action and it was overwritten by nil from another one(the effect in browser was 404 error), so we are taking the possibleResponse from action and checking if it isn't nil before assigning it to response that we are about to sent.

@naturallymitchell
Copy link
Member Author

if we don't need it, then let's remove it

@naturallymitchell naturallymitchell changed the title possibleResponse remove possibleResponse Dec 27, 2018
@aleksanderwlodarczyk
Copy link
Contributor

9a939a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants