Withers #87
Open
Withers #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like it repeats #84 with the minor differences. demanded feature :) |
|
Thanks for the PR, however as I said in #84, it may be better to make your own crate. I haven't used this in several years and I don't really think the features it offers and the way it does that are very good. |
Closed
This was referenced Dec 26, 2023
dcroote
pushed a commit
to rust-bio/rust-bio
that referenced
this pull request
Dec 27, 2023
getset is no longer recommended by its maintainer: jbaublitz/getset#87 (comment) & is thus unlikely to update to `syn 2`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. It would be nice to have "moving" setters that modifies one field. I've implemented it to use in my project and seems it works fine.
Feel free to consider this change to the main stream.