From 6b54420844f83e403f21bb399d03fe61953307a8 Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sat, 1 Dec 2018 14:06:43 +0100 Subject: [PATCH 1/7] Corrected typo Default forecastLayout is "tiled", not "true" --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 345b35c..f286695 100644 --- a/README.md +++ b/README.md @@ -131,7 +131,7 @@ Find out your latitude and longitude here: forecastLayout - Can be set to tiled or table. How to display hourly and forecast information. See below for screenshot examples of each.

Type String
Defaults to true + Can be set to tiled or table. How to display hourly and forecast information. See below for screenshot examples of each.

Type String
Defaults to tiled label_maximum @@ -188,4 +188,4 @@ Find out your latitude and longitude here: ## Layouts -![Layouts](/../screenshots/forecast-layouts.png?raw=true "Layouts") \ No newline at end of file +![Layouts](/../screenshots/forecast-layouts.png?raw=true "Layouts") From d3062be384755d68c0f591c01e2f1a8311b7168d Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sat, 1 Dec 2018 14:25:09 +0100 Subject: [PATCH 2/7] Added info how to use label_timeFormat Added advice for users with 24h format on how to set this to the short "24h" format. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f286695..0bf0bd8 100644 --- a/README.md +++ b/README.md @@ -147,7 +147,7 @@ Find out your latitude and longitude here: label_timeFormat - How you want the time formatted for hourly forecast display. Accepts any valid moment.js format (https://momentjs.com/docs/#/displaying/format/).

Type String
Defaults to "h a" (e.g.: 9 am) + How you want the time formatted for hourly forecast display. Accepts any valid moment.js format (https://momentjs.com/docs/#/displaying/format/).
The short 24h format kann be displayed by "H[h]" (e.g.: 14h)

Type String
Defaults to "h a" (e.g.: 9 am) label_days From 56ddc9589897b3d7e606d31fd0dcf404e4e40d08 Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sat, 1 Dec 2018 15:31:57 +0100 Subject: [PATCH 3/7] =?UTF-8?q?Corrected=20H[h]=20to=20k[h]=20f=C3=BCr=20s?= =?UTF-8?q?hort=2024h=20format?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0bf0bd8..ca50754 100644 --- a/README.md +++ b/README.md @@ -147,7 +147,7 @@ Find out your latitude and longitude here: label_timeFormat - How you want the time formatted for hourly forecast display. Accepts any valid moment.js format (https://momentjs.com/docs/#/displaying/format/).
The short 24h format kann be displayed by "H[h]" (e.g.: 14h)

Type String
Defaults to "h a" (e.g.: 9 am) + How you want the time formatted for hourly forecast display. Accepts any valid moment.js format (https://momentjs.com/docs/#/displaying/format/).
The short 24h format kann be displayed by "k[h]" (e.g.: 14h)

Type String
Defaults to "h a" (e.g.: 9 am) label_days From 9ff80b5bb75c6ddc36b72a7f740236fb3465bcd7 Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sun, 2 Dec 2018 00:41:39 +0100 Subject: [PATCH 4/7] Added CSS style for module-header Layout analog to header layout --- MMM-DarkSkyForecast.css | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/MMM-DarkSkyForecast.css b/MMM-DarkSkyForecast.css index b90fbae..8f2a92e 100644 --- a/MMM-DarkSkyForecast.css +++ b/MMM-DarkSkyForecast.css @@ -77,6 +77,20 @@ margin: 15px 0; } +/* Module Header below current conditions */ + +.MMM-DarkSkyForecast .module-header { + text-transform: uppercase; + font-size: 15px; + font-family: "Roboto Condensed", Arial, Helvetica, sans-serif; + font-weight: 400; + border-bottom: 1px solid #666; + line-height: 15px; + padding-bottom: 5px; + padding-top: 5px; + margin-bottom: 10px; + color: #999; +} /* ------------ Forecast ------------ */ From 68026ce8b25dd13db73062effa207529c1d38ff1 Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sun, 2 Dec 2018 00:50:15 +0100 Subject: [PATCH 5/7] forecast table header and hidden header icons Optionally hide the icons from the forecast table column header Optionally show a header above the forecast table --- MMM-DarkSkyForecast.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/MMM-DarkSkyForecast.js b/MMM-DarkSkyForecast.js index d561fb1..eac2922 100644 --- a/MMM-DarkSkyForecast.js +++ b/MMM-DarkSkyForecast.js @@ -10,6 +10,8 @@ Module.register("MMM-DarkSkyForecast", { showCurrentConditions: true, showExtraCurrentConditions: true, showSummary: true, + forecasttableheadertext: '', + showforecasttablecolumnheadericons: true, showHourlyForecast: true, hourlyForecastInterval: 3, maxHourliesToShow: 3, @@ -306,8 +308,14 @@ Module.register("MMM-DarkSkyForecast", { summaryWrapper.appendChild(summary); wrapper.appendChild(summaryWrapper); - - + } + + //forecasttableheadertext + if (this.config.forecasttableheadertext != "") { + var forecastheader = document.createElement("div"); + forecastheader.className = "module-header"; + forecastheader.innerHTML = this.config.forecasttableheadertext; + wrapper.appendChild(forecastheader); } var forecastWrapper; @@ -315,7 +323,7 @@ Module.register("MMM-DarkSkyForecast", { forecastWrapper = document.createElement("div"); forecastWrapper.className = "forecast-container"; - if (this.config.forecastLayout == "table") { + if (this.config.forecastLayout == "table" && this.config.showforecasttablecolumnheadericons) { var headerRow = document.createElement("div"); headerRow.className = "header-row"; @@ -694,4 +702,4 @@ Module.register("MMM-DarkSkyForecast", { } -}); \ No newline at end of file +}); From aacba6e18277ab943fe90c04a086fac2e5771cad Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sun, 2 Dec 2018 00:59:45 +0100 Subject: [PATCH 6/7] Adapted CamelCase style --- MMM-DarkSkyForecast.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/MMM-DarkSkyForecast.js b/MMM-DarkSkyForecast.js index eac2922..48a31f6 100644 --- a/MMM-DarkSkyForecast.js +++ b/MMM-DarkSkyForecast.js @@ -10,8 +10,8 @@ Module.register("MMM-DarkSkyForecast", { showCurrentConditions: true, showExtraCurrentConditions: true, showSummary: true, - forecasttableheadertext: '', - showforecasttablecolumnheadericons: true, + forecastTableHeaderText: '', + showForecastTableColumnHeaderIcons: true, showHourlyForecast: true, hourlyForecastInterval: 3, maxHourliesToShow: 3, @@ -310,12 +310,12 @@ Module.register("MMM-DarkSkyForecast", { wrapper.appendChild(summaryWrapper); } - //forecasttableheadertext - if (this.config.forecasttableheadertext != "") { - var forecastheader = document.createElement("div"); - forecastheader.className = "module-header"; - forecastheader.innerHTML = this.config.forecasttableheadertext; - wrapper.appendChild(forecastheader); + //forecastTableHeaderText + if (this.config.forecastTableHeaderText != "") { + var forecastHeader = document.createElement("div"); + forecastHeader.className = "module-header"; + forecastHeader.innerHTML = this.config.forecastTableHeaderText; + wrapper.appendChild(forecastHeader); } var forecastWrapper; @@ -323,7 +323,7 @@ Module.register("MMM-DarkSkyForecast", { forecastWrapper = document.createElement("div"); forecastWrapper.className = "forecast-container"; - if (this.config.forecastLayout == "table" && this.config.showforecasttablecolumnheadericons) { + if (this.config.forecastLayout == "table" && this.config.showForecastTableColumnHeaderIcons) { var headerRow = document.createElement("div"); headerRow.className = "header-row"; From abdd72154f331bea09a7dfcdb7f2897cfe4a3d6d Mon Sep 17 00:00:00 2001 From: rudibarani <7797301+rudibarani@users.noreply.github.com> Date: Sun, 2 Dec 2018 01:02:14 +0100 Subject: [PATCH 7/7] Updated info on new config options Info for: - forecastTableHeaderText - showForecastTableColumnHeaderIcons --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index ca50754..5c28658 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,14 @@ Find out your latitude and longitude here: showSummary Whether to show the forecast summary.

Type Boolean
Defaults to true + + forecastTableHeaderText + Show a header above the forecast table. Can be used instead of the regular header.

Type String
Defaults to '' + + + showForecastTableColumnHeaderIcons + Whether to show icons for the columns of the forecast table.

Type Boolean
Defaults to true + showHourlyForecast Whether to show hourly forecast information. when set to true it works with the hourlyForecastInterval and maxHourliesToShow parameters.

Type Boolean
Defaults to true