Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to specify the delimiter #39

Open
bamby084 opened this issue Jun 8, 2023 · 6 comments · May be fixed by #51
Open

option to specify the delimiter #39

bamby084 opened this issue Jun 8, 2023 · 6 comments · May be fixed by #51
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bamby084
Copy link

bamby084 commented Jun 8, 2023 •
edited
Loading

Currently the library only allows comma as delimiter. It would be great to have an option to set the delimiter (for instance semi-colon) when initializing.
@jcubic
Copy link
Owner

jcubic commented Jun 8, 2023

Good idea, do you want to contribute with this feature?

@jcubic jcubic added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 28, 2023
@Ashish-simpleCoder
Copy link

Can I work on this?

@jcubic
Copy link
Owner

jcubic commented Aug 3, 2023

Sure

@Ashish-simpleCoder
Copy link

pls assign me

@jcubic
Copy link
Owner

jcubic commented Aug 3, 2023 •
edited
Loading

No one on GitHub uses assignments (unless you have a project with thousands contributors), you don't need this to work on the issue.

@rog404 rog404 linked a pull request Oct 3, 2024 that will close this issue
Open
@rog404
Copy link

rog404 commented Oct 3, 2024

Hello @jcubic

I just made a pull request with an alternative solution for the issue. I'd love to know what you think about my suggestion!

#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new delimiter option rog404/tagger
4 participants
@jcubic @bamby084 @Ashish-simpleCoder @rog404