From 62594e4c7e1be9b3d93f412f7fec0b34e07676e1 Mon Sep 17 00:00:00 2001 From: jos <17252150+jostnes@users.noreply.github.com> Date: Fri, 2 Jun 2023 13:03:15 +0800 Subject: [PATCH] update plugin version and add branch condition for notification --- .buildkite/cache-builder.yml | 2 +- .buildkite/commands/run-ui-tests.sh | 7 ++++++- .buildkite/commands/run-unit-tests.sh | 7 ++++++- .buildkite/pipeline.yml | 14 +------------- .buildkite/release-builds.yml | 2 +- 5 files changed, 15 insertions(+), 17 deletions(-) diff --git a/.buildkite/cache-builder.yml b/.buildkite/cache-builder.yml index 4f3d3fafc7d2..0b44a369a583 100644 --- a/.buildkite/cache-builder.yml +++ b/.buildkite/cache-builder.yml @@ -7,7 +7,7 @@ common_params: # Common plugin settings to use with the `plugins` key. - &common_plugins - - automattic/a8c-ci-toolkit#2.15.1 + - automattic/a8c-ci-toolkit#2.17.0 - automattic/git-s3-cache#1.1.4: bucket: "a8c-repo-mirrors" repo: "automattic/wordpress-ios/" diff --git a/.buildkite/commands/run-ui-tests.sh b/.buildkite/commands/run-ui-tests.sh index abf47ce38e17..fe169bf885ad 100755 --- a/.buildkite/commands/run-ui-tests.sh +++ b/.buildkite/commands/run-ui-tests.sh @@ -50,6 +50,11 @@ else echo "The UI Tests, ran during the '🔬 Testing' step above, have failed." echo "For more details about the failed tests, check the Buildkite annotation, the logs under the '🔬 Testing' section and the \`.xcresult\` and test reports in Buildkite artifacts." fi -annotate_test_failures "build/results/JetpackUITests.xml" + +if [[ $BUILDKITE_BRANCH == trunk ]] || [[ $BUILDKITE_BRANCH == release/* ]]; then + annotate_test_failures "build/results/JetpackUITests.xml" --slack "build-and-ship" +else + annotate_test_failures "build/results/JetpackUITests.xml" +fi exit $TESTS_EXIT_STATUS diff --git a/.buildkite/commands/run-unit-tests.sh b/.buildkite/commands/run-unit-tests.sh index e014eb780aa7..828f7ea1d9b4 100755 --- a/.buildkite/commands/run-unit-tests.sh +++ b/.buildkite/commands/run-unit-tests.sh @@ -36,6 +36,11 @@ else echo "The Unit Tests, ran during the '🔬 Testing' step above, have failed." echo "For more details about the failed tests, check the Buildkite annotation, the logs under the '🔬 Testing' section and the \`.xcresult\` and test reports in Buildkite artifacts." fi -annotate_test_failures "build/results/WordPress.xml" + +if [[ $BUILDKITE_BRANCH == trunk ]] || [[ $BUILDKITE_BRANCH == release/* ]]; then + annotate_test_failures "build/results/WordPress.xml" --slack "build-and-ship" +else + annotate_test_failures "build/results/WordPress.xml" +fi exit $TESTS_EXIT_STATUS diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 25e350421a2f..0cf2db6a8a2e 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -2,7 +2,7 @@ common_params: # Common plugin settings to use with the `plugins` key. - &common_plugins - - automattic/a8c-ci-toolkit#2.15.1 + - automattic/a8c-ci-toolkit#2.17.0 - automattic/git-s3-cache#1.1.4: bucket: "a8c-repo-mirrors" repo: "automattic/wordpress-ios/" @@ -73,10 +73,6 @@ steps: notify: - github_commit_status: context: "Unit Tests" - - slack: - channels: - - "#mobile-apps-tests-notif" - if: build.state == "failed" && build.branch == "trunk" ################# # UI Tests @@ -94,10 +90,6 @@ steps: notify: - github_commit_status: context: "UI Tests (iPhone)" - - slack: - channels: - - "#mobile-apps-tests-notif" - if: build.state == "failed" && build.branch == "trunk" - label: "🔬 :jetpack: UI Tests (iPad)" command: .buildkite/commands/run-ui-tests.sh 'iPad Air (5th generation)' @@ -110,10 +102,6 @@ steps: notify: - github_commit_status: context: "UI Tests (iPad)" - - slack: - channels: - - "#mobile-apps-tests-notif" - if: build.state == "failed" && build.branch == "trunk" ################# # Linters diff --git a/.buildkite/release-builds.yml b/.buildkite/release-builds.yml index 5666d3bb0006..120d158d6dc8 100644 --- a/.buildkite/release-builds.yml +++ b/.buildkite/release-builds.yml @@ -4,7 +4,7 @@ common_params: # Common plugin settings to use with the `plugins` key. - &common_plugins - - automattic/a8c-ci-toolkit#2.15.1 + - automattic/a8c-ci-toolkit#2.17.0 - automattic/git-s3-cache#1.1.4: bucket: "a8c-repo-mirrors" repo: "automattic/wordpress-ios/"