Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yes/No/maybe icons and colors got lost with latest release #274

Closed
doobry-systemli opened this issue Oct 31, 2019 · 7 comments · Fixed by #289
Closed

Yes/No/maybe icons and colors got lost with latest release #274

doobry-systemli opened this issue Oct 31, 2019 · 7 comments · Fixed by #289
Labels

Comments

@doobry-systemli
Copy link

While I really like the clean new design of croodle 0.6.0 (well done!), I miss the colors and icons of Yes/No/maybe options in polls that earlier versions had. They helped a lot do visually detect patterns in the results table.

In croodle 0.5.6:

croodle_0 5 6

In croodle 0.6.0-rc.1:

croodle_0 6 0-rc 1

@jelhan
Copy link
Owner

jelhan commented Oct 31, 2019

@sappor0 I think the styles were removed in #205. Was this change intended?

@jelhan jelhan added the bug label Oct 31, 2019
@sappor0
Copy link
Contributor

sappor0 commented Nov 1, 2019

The change was intentional to reduce visual clutter. I agree that the removed colour coding is less clear though. Moving forward I think the idea was that the whole results screen should get a revamp that's why I didn't spend more time on this.

As a interim step I propose something like this:

Screenshot from 2019-11-01 14-51-18

@doobry-systemli
Copy link
Author

I very much like @sappor0's proposal! 👍

@jelhan
Copy link
Owner

jelhan commented Nov 1, 2019

@sappor0 Thanks a lot for your quick feedback. The proposed interim solution looks great. Do you have time to implement that one yourself?

@sappor0
Copy link
Contributor

sappor0 commented Nov 10, 2019

@jelhan Sorry for the late reply. I will try to put together a MR within the next week.

@sappor0
Copy link
Contributor

sappor0 commented Nov 10, 2019

Ah. Just saw your MR. Awesome!

@sappor0
Copy link
Contributor

sappor0 commented Nov 12, 2019

@jelhan Incidentally I've put the thumb screws on the designer who said they would make a wireframe for the results screen. So hopefully we should have something to discuss in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants