-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon used for save button is confusing #294
Comments
@sappor0 I'm not that used to Open Iconic. Is there an icon you could recommend for a save button? Tried to filter there icons by save but that returned nothing. |
… So we're not the first people to have this issue at least iconic/open-iconic#41 There is some debate about the validity of the save icon with the diskette as it is obsolete skeumorphism and most young people don't know what it represents. (https://graphicdesign.stackexchange.com/questions/323/new-generation-of-save-icon-that-is-not-a-disk) – The counter-argument to a new save icon is that an icon needs to be simply iconic and ubiquitous and not realistic. Me, I'm somewhere in the middle. I think we can use something a little different and it would still work. (especially since we're combining it with a label) I think there are a few likely candidates we can use (in order of my personal preference): |
i'd vote for the checkmark icon. ich think the important meaning here is that it is final step which completes the action |
I tend toward the cloud upload (even so it's not a file upload) or the document one. But I don't have a strong opinion here.
This argument only applies for the save button on poll creation and for the one to save a participation, isn't it? Would you use a different icon on the button to save a participation? |
Your are confirming your entries. So i think, it still makes sense in this case. |
Three persons, three opinions. 😆 But I noticed that I hadn't given any arguments. So let me quickly give some:
@sappor0 Thanks a lot for putting the options together with context. Would you feel comfortable with making a decision? |
Hm. Well I'm split 50/50 between cloud icon and checkmark.
… So even though I'm still quite torn I think it should be the checkmark because it is the most accessible solution. |
@sappor0 sounds good. Thanks a lot for driving this discussion. Do you have time to provide a PR? |
Adds a <SaveButton> component that renders a save button similar to <NextButton> but using a special icon that helps to distinguish both. Also removes the block mode for <NextButton> component and some arguments that aren't needed anymore. Closes #294
Adds a <SaveButton> component that renders a save button similar to <NextButton> but using a special icon that helps to distinguish both. Also removes the block mode for <NextButton> component and some arguments that aren't needed anymore. Closes #294
Croodle uses the same icon for next as for save button. While it's a good fit for next button it does not make much sense for save button.
The icon for the save button should be changed.
This save button is used at two places: at last step of poll creation form and for participation.
I guess there is a technical issue for this situation: both buttons use the same component, which is called
<NextButton>
. It could be used in block mode to overrule default text. I think it's time for a new component<SaveButton>
rather than adding more functionality to<NextButton>
to alter the icon.The text was updated successfully, but these errors were encountered: