From d1b4cf21e5d3a7ef95baad4391f96af54eb0640a Mon Sep 17 00:00:00 2001 From: Charles Ewert Date: Fri, 8 Nov 2024 22:59:20 -0500 Subject: [PATCH 1/5] remove unnecessary code. wait until we have data before we create the row --- components/home/HomeRows.bs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/components/home/HomeRows.bs b/components/home/HomeRows.bs index d691cb154..c0ab55657 100644 --- a/components/home/HomeRows.bs +++ b/components/home/HomeRows.bs @@ -411,15 +411,6 @@ end sub ' createContinueWatchingRow: Creates a row displaying items the user can continue watching ' sub createContinueWatchingRow() - sectionName = tr("Continue Watching") - - if not sectionExists(sectionName) - nextUpRow = m.top.content.CreateChild("HomeRow") - nextUpRow.title = sectionName - nextUpRow.imageWidth = homeRowItemSizes.WIDE_POSTER[0] - nextUpRow.cursorSize = homeRowItemSizes.WIDE_POSTER - end if - ' Load the Continue Watching Data m.LoadContinueWatchingTask.observeField("content", "updateContinueWatchingItems") m.LoadContinueWatchingTask.control = "RUN" From b4204303af93e3effb35eca1bb80dedb0cd9ef04 Mon Sep 17 00:00:00 2001 From: jellyfin-bot Date: Sun, 10 Nov 2024 01:24:00 +0000 Subject: [PATCH 2/5] Bump build version --- Makefile | 2 +- manifest | 2 +- package-lock.json | 4 ++-- package.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index ac5cf59b9..058051740 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ # If you want to get_images, you'll also need convert from ImageMagick ########################################################################## -VERSION := 2.2.3 +VERSION := 2.2.4 ## usage diff --git a/manifest b/manifest index f8ee154eb..ddf587fb8 100644 --- a/manifest +++ b/manifest @@ -3,7 +3,7 @@ title=Jellyfin major_version=2 minor_version=2 -build_version=3 +build_version=4 ### Main Menu Icons / Channel Poster Artwork diff --git a/package-lock.json b/package-lock.json index e4b1aac7f..44ec1ea9b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "jellyfin-roku", - "version": "2.2.3", + "version": "2.2.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "jellyfin-roku", - "version": "2.2.3", + "version": "2.2.4", "hasInstallScript": true, "license": "GPL-2.0", "dependencies": { diff --git a/package.json b/package.json index ddf5a74d3..09fb41e6e 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "jellyfin-roku", "type": "module", - "version": "2.2.3", + "version": "2.2.4", "description": "Roku app for Jellyfin media server", "dependencies": { "@rokucommunity/bslib": "0.1.1", From f00038a61adef78a5d39ed4797f736e1955d5a27 Mon Sep 17 00:00:00 2001 From: Charles Ewert Date: Tue, 12 Nov 2024 13:08:51 -0500 Subject: [PATCH 3/5] stop adding h264 to codec string twice --- source/utils/deviceCapabilities.bs | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/source/utils/deviceCapabilities.bs b/source/utils/deviceCapabilities.bs index 44cc05d66..a7dd27034 100644 --- a/source/utils/deviceCapabilities.bs +++ b/source/utils/deviceCapabilities.bs @@ -211,19 +211,6 @@ function getTranscodingProfiles() as object ' ' AVC / h264 / MPEG4 AVC for each container in transcodingContainers - if di.CanDecodeVideo({ Codec: "h264", Container: container }).Result - if container = "mp4" - ' check for codec string before adding it - if mp4VideoCodecs.Instr(0, ",h264") = -1 - mp4VideoCodecs = mp4VideoCodecs + ",h264" - end if - else if container = "ts" - ' check for codec string before adding it - if tsVideoCodecs.Instr(0, ",h264") = -1 - tsVideoCodecs = tsVideoCodecs + ",h264" - end if - end if - end if if di.CanDecodeVideo({ Codec: "mpeg4 avc", Container: container }).Result if container = "mp4" ' check for codec string before adding it From a79c25978213fce255fbdfe848e648829730a318 Mon Sep 17 00:00:00 2001 From: Charles Ewert Date: Tue, 12 Nov 2024 13:18:24 -0500 Subject: [PATCH 4/5] force a full transcode for AV1 instead of direct streaming --- source/utils/deviceCapabilities.bs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/source/utils/deviceCapabilities.bs b/source/utils/deviceCapabilities.bs index a7dd27034..f0f4413ab 100644 --- a/source/utils/deviceCapabilities.bs +++ b/source/utils/deviceCapabilities.bs @@ -288,11 +288,9 @@ function getTranscodingProfiles() as object end if ' AV1 - ' CanDecodeVideo() returns false for AV1 when the container is provided - ' Manually add AV1 to the mp4VideoCodecs list if support is detected - if di.CanDecodeVideo({ Codec: "av1" }).Result - mp4VideoCodecs = mp4VideoCodecs + ",av1" - end if + ' direct streaming av1 is not supported on roku + ' force a full transcode by omitting av1 from the transcoding profile + ' https://community.roku.com/t5/Roku-Developer-Program/HLS-fMP4-No-Audio/td-p/607399 ' AUDIO CODECS for each container in transcodingContainers From ffac3fe799190c9a9308e5151f471b7747200171 Mon Sep 17 00:00:00 2001 From: Jimi Date: Fri, 15 Nov 2024 15:17:05 -0700 Subject: [PATCH 5/5] Subtitle should be on when a default one has been selected by the user. --- components/video/VideoPlayerView.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/video/VideoPlayerView.bs b/components/video/VideoPlayerView.bs index 109a5569c..ea9758071 100644 --- a/components/video/VideoPlayerView.bs +++ b/components/video/VideoPlayerView.bs @@ -466,8 +466,8 @@ sub onVideoContentLoaded() ' If IsForced, make sure to remember the Roku global setting so we ' can set it back when the video is done playing. m.originalClosedCaptionState = m.top.globalCaptionMode - m.top.globalCaptionMode = "On" end if + m.top.globalCaptionMode = "On" m.top.subtitleTrack = m.top.availableSubtitleTracks[availableSubtitleTrackIndex].TrackName end if end if