Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nit] Label horizontal lines in text left-to-right #29

Open
MarcinCiura opened this issue Nov 28, 2017 · 4 comments
Open

[Nit] Label horizontal lines in text left-to-right #29

MarcinCiura opened this issue Nov 28, 2017 · 4 comments
Assignees

Comments

@MarcinCiura
Copy link

Examples up to Proposition I.XXXV:
Propositions I.X, I.XI, I.XII: DB and CD are labelled in the opposite direction to their appearance in the diagram. BD and DC would be more natural.
Proposition I.XIV: CD should better be referred to as DC
Proposition I.XXIV: BD should better be DB

@jemmybutton jemmybutton self-assigned this Nov 28, 2017
@jemmybutton
Copy link
Owner

Thanks! These are fixed: 65f086c
It seems that this can be automated (e. g. in text always label lines with angle <= pi/4 from left to right and with angle > pi/4 from top to bottom, or something like that), but i'm not sure if there are cases when it's necessary to control this and if so, what would be the best way to do it.

@MarcinCiura
Copy link
Author

I don't think such automation will do the right thing with BC in Proposition I.2. A strict test for angle = 0 is safer.

@jemmybutton
Copy link
Owner

I'm not sure even without automation what's the right way in this case, it's horizontal and would be displayed as CB, is this so bad? But anyway, for now i can't implement any rule (like strict test for angle = 0), there's no mechanism to do it. I'll try to add it and we'll see what yields better results.

@MarcinCiura
Copy link
Author

FWIW, my previous comment made little sense because I was looking at the release PDF, where BC was merely close to horizontal, not at the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants