Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting request for Zimperium zScan plugin #4102

Open
exlegalalien opened this issue Sep 25, 2024 · 10 comments
Open

Hosting request for Zimperium zScan plugin #4102

exlegalalien opened this issue Sep 25, 2024 · 10 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@exlegalalien
Copy link

Repository URL

https://github.com/Zimperium/zscan-plugin-jenkins

New Repository Name

zscan-upload-plugin

Description

The plugin uploads mobile builds to zScan for analysis and (optionally) downloads security and privacy assessment reports. While there are other mobile security scanning plugins in the marketplace, the upload process is specific to Zimperium and it is beneficial to have an official plugin for our cusotmers to use. More information: Zimperium zScan.

GitHub users to have commit permission

@Oliver-Zimperium
@exlegalalien

Jenkins project users to have release permission

legalalien
oliver_williams

Issue tracker

Jira

@exlegalalien exlegalalien added the hosting-request Request to host a component in jenkinsci label Sep 25, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.12)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Sep 25, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: oliver_williams (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: legalalien, oliver_williams (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The dependency com.google.code.gson:gson should be replaced with a dependency to the api plugin io.jenkins.plugins:gson-api

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 4 finding(s) 🔍.

Please follow the instructions below for every identified issues:

  • Implement the recommended fix to address the issue.
  • If you think it's a false positive, suppress the warning directly within the code.
  • Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

  • If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
  • If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing permission check

You can find detailed information about this finding here.

ZDevUploadPlugin.java#548
Potential missing permission check in DescriptorImpl#doValidateCredentials

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

LoginResponse.java#14
Field should be reviewed whether it stores a password and is serialized to disk: refreshToken
LoginResponse.java#10
Field should be reviewed whether it stores a password and is serialized to disk: accessToken
RefreshCredentials.java#5
Field should be reviewed whether it stores a password and is serialized to disk: refreshToken

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Sep 25, 2024
@exlegalalien
Copy link
Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Sep 25, 2024
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Sep 25, 2024
@exlegalalien
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Sep 25, 2024
@exlegalalien exlegalalien changed the title Fork Zimperium zScan plugin to the jenkinsci organization Hosting request for Zimperium zScan plugin to the jenkinsci organization Oct 25, 2024
@exlegalalien exlegalalien changed the title Hosting request for Zimperium zScan plugin to the jenkinsci organization Hosting request for Zimperium zScan plugin Oct 25, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

1 similar comment
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@exlegalalien
Copy link
Author

Hello Jenkins Hosting Team,

How can we move this request forward?

Thanks!

@timja @mawinter69 @NotMyFault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

2 participants