Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oidc-provider #3094

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Add oidc-provider #3094

merged 7 commits into from
Apr 12, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 5, 2024

Would like to catch things like jenkinsci/jjwt-api-plugin#88 (comment) earlier.

@jglick jglick requested a review from a team as a code owner April 5, 2024 00:56
@jglick jglick added enhancement New feature or request weekly-test labels Apr 5, 2024
MarkEWaite
MarkEWaite approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) April 5, 2024 01:48
@jglick jglick marked this pull request as draft April 5, 2024 12:21
auto-merge was automatically disabled April 5, 2024 12:21

Pull request was converted to draft

@jglick
Copy link
Member Author

jglick commented Apr 5, 2024

Fails I think due to use of an older parent POM. Will need to update that first.

@basil
Copy link
Member

basil commented Apr 5, 2024

I think

SUREFIRE-1964 FTR

@jglick jglick marked this pull request as ready for review April 10, 2024 20:44
@jglick
Copy link
Member Author

jglick commented Apr 11, 2024 

java.lang.AssertionError: 

Expected: an instance of io.jenkins.plugins.oidc_provider.KeysTest$ExtraProvider
     but: <io.jenkins.blueocean.rest.impl.pipeline.credential.BlueOceanCredentialsProvider@5c710bdd> is a io.jenkins.blueocean.rest.impl.pipeline.credential.BlueOceanCredentialsProvider
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at io.jenkins.plugins.oidc_provider.KeysTest.extraCredentialsProvider(KeysTest.java:90)

👀

@jglick jglick marked this pull request as draft April 11, 2024 11:39
@jglick jglick mentioned this pull request Apr 11, 2024
Merged
@jglick jglick marked this pull request as ready for review April 11, 2024 18:38
@jglick
Copy link
Member Author

jglick commented Apr 12, 2024

https://ci.jenkins.io/job/Tools/job/bom/job/PR-3094/4/testReport/io.jenkins.blueocean.rest.impl.pipeline/PipelineNodeTest/pct_blueocean_plugin_weekly___submitInputPostBlockWithParallelStages/ is pending jenkinsci/blueocean-plugin#2555 I think, thus #3114

@jglick jglick enabled auto-merge (squash) April 12, 2024 18:44
@jglick jglick merged commit 21351a1 into jenkinsci:master Apr 12, 2024
178 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request weekly-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @basil @MarkEWaite