Create GreenBallFilter.java #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects the path used when to return gifs when the color-blind option is turned on.
|
@nfalco79 would you check/merge this request please? |
|
Please provide a test case |
sagarkhushalani
force-pushed
the
patch-2
branch
from
29d07b9 to
8916ef6
Compare
nfalco79
reviewed
Jan 10, 2022
|
|
||
| @Test | ||
| public void patternShouldMatchColorblind() { |
There was a problem hiding this comment.
As test I mean a request done to the filter to load blue.gif image returns a correct URL to the green gif image
create a variable JenkinsRule and than you can navigate rule.createWebClient().goTo("/nocacheImages/colorblind/48x48/blue.gif") for example and the URL it returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects the path used when to return gifs when the color-blind option is turned on.
Issue: https://issues.jenkins.io/browse/JENKINS-66780
#JENKINS-66780