[JENKINS-66258] Retrieve non transient actions to prevent deadlock

[Dohbedoh]

JENKINS-66258 do not lookup transient action factories for a AbstractTestResultAction to prevent deadlock through workflow-api.

NOTE: As discussed in the issue, a further improvement of this plugin would be to handle work asynchronously from LogstashOutputStream.eol. What we ought to do here is a fix to prevent deadlocks int he meantime.

Testing done

Run a simple pipeline with a junit step:

node {
    
    [...]
    
    sh "mvn clean install"
    
    junit(
        allowEmptyResults: true,
        testResults: '**/target/surefire-reports/**/*.xml,**/target/failsafe-reports/**/*.xml,**/target/invoker-reports/**/*.xml'
    )
}

Validate in debug that the TestResultAction is retrieved with the proper details.
Validate in debug that the LogstashOutputStream.eol does not go through TransientActionFactory#factoriesFor

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[Dohbedoh]

ping @jakub-bochenski

[jakub-bochenski]

hey, I'm out of my depth here :)
I've read the ticket but I haven't been following the related changes in Jenkins infrastructure.

Using a deprecated method that has "No clear purpose" seems bad, though I guess not as bad as causing a deadlock.

What would be the proper way to solve it?

[jakub-bochenski]

why not getActions(Class) ?

[jakub-bochenski]

ok, I guess getActions(Class) does try to get transient actions and that is the problem
wouldn't it better if the build.getAction(Class) were smart enough to determine that I'm requesting a non-transient action?