From 1aea594a321f5455b9abd0a8fbf64dd14a0c1855 Mon Sep 17 00:00:00 2001
From: judovana <jvanek@redhat.com>
Date: Fri, 18 Oct 2024 09:59:09 +0200
Subject: [PATCH] JENKINS-73971  Extract event handlers in
 NestedViewsSearch/search-results (#48)

* JENKINS-73971  Extract event handlers in NestedViewsSearch/search-results.jelly

* Adding onClick dynamically

moving adjunct after creation of elements

* replaced return false by  event.preventDefault();
---
 .../NestedViewsSearch/search-results.jelly    |  7 +++---
 .../NestedViewsSearch/searchscripts.js        | 25 +++++++++++++++++++
 2 files changed, 28 insertions(+), 4 deletions(-)
 create mode 100644 src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/searchscripts.js

diff --git a/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/search-results.jelly b/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/search-results.jelly
index 8fcbffd..28bcc37 100644
--- a/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/search-results.jelly
+++ b/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/search-results.jelly
@@ -6,10 +6,9 @@
     <l:layout title="${%Search for} '${q}'">
         <l:side-panel>
             <h2><l:icon class="icon-help icon-sm" /> Search help</h2>
-            <a onclick="document.getElementById('button_expand_2_1').style.display = 'none'; document.getElementById('button_collapse_2_1').style.display = 'inline'; document.getElementById('details_2_1').style.display = 'block'; return false;"
-               style="font-size: smaller; display: inline" href="#" id="button_expand_2_1">Search History (expand)</a>
-            <a onclick="document.getElementById('button_collapse_2_1').style.display = 'none';document.getElementById('details_2_1').style.display = 'none';document.getElementById('button_expand_2_1').style.display = 'inline';                                                 return false;"
-               style="font-size: smaller; display: none" href="#" id="button_collapse_2_1">Search History (collapse)</a>
+            <a style="font-size: smaller; display: inline" href="#" id="button_expand_2_1">Search History (expand)</a>
+            <a style="font-size: smaller; display: none" href="#" id="button_collapse_2_1">Search History (collapse)</a>
+            <st:adjunct includes="hudson.plugins.nested_view.NestedViewsSearch.searchscripts"/>
             <div style="display: none" id="details_2_1">
                 <ol>
                 <j:forEach var="hist" items="${it.getHistory()}">
diff --git a/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/searchscripts.js b/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/searchscripts.js
new file mode 100644
index 0000000..df77b53
--- /dev/null
+++ b/src/main/resources/hudson/plugins/nested_view/NestedViewsSearch/searchscripts.js
@@ -0,0 +1,25 @@
+        // <![CDATA[
+
+function nvwp_showHide_button_2_1_show(event) {
+  document.getElementById('button_expand_2_1').style.display = 'none';
+  document.getElementById('button_collapse_2_1').style.display = 'inline';
+  document.getElementById('details_2_1').style.display = 'block';
+  event.preventDefault();
+}
+function nvwp_showHide_button_2_1_hide(event) {
+  document.getElementById('button_collapse_2_1').style.display = 'none';
+  document.getElementById('details_2_1').style.display = 'none';
+  document.getElementById('button_expand_2_1').style.display = 'inline';
+  event.preventDefault();
+}
+
+const exEl = document.getElementById("button_expand_2_1");
+exEl.addEventListener("click", nvwp_showHide_button_2_1_show);
+
+const colEl = document.getElementById("button_collapse_2_1");
+colEl.addEventListener("click", nvwp_showHide_button_2_1_hide);
+
+
+
+        // ]]>
+