Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciation warning on Ember 2.1.0 #8

Open
jniechcial opened this issue Nov 2, 2015 · 2 comments
Open

Depreciation warning on Ember 2.1.0 #8

jniechcial opened this issue Nov 2, 2015 · 2 comments

Comments

@jniechcial
Copy link
Contributor

I bumped into this depreciation after updating Ember to 2.1.0:

DEPRECATION: The `initialize` method for Application initializer 'growl' should take only one argument - `App`, an instance of an `Application`.

The easiest fix would be to just change initializer. However, I think that it is rather more useful to remove initializer at all and provide just a service object. Thus, user would inject it where needed not in each route and controller.

What do you think?

@jerel
Copy link
Owner

jerel commented Nov 2, 2015

I agree. If you want to make a pull request I'm happy to review it and tag a new version

@jniechcial
Copy link
Contributor Author

@jerel Sorry for delay but I couldn't find any time to focus on ember-cli-growl. I am working on that but I still haven't finished and from my plans for this week I see that I will start again at most on next Monday. I also bumped into another issue while upgrading to ember-cli 1.13.12 regarding css import in index.js. I will try to cover it also. Please give me a sign if you would work on these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants