Free URI with destruction of client to avoid mem leaks #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinNowack
force-pushed
the
fix_leak_uri
branch
from
c58adfe
to
67ebcab
Compare
|
This seems a bit overkill. Can't we just free the uri after creating the client? Or can we lookup the uri object in the finalizer for the client object? |
|
@jeroen To be honest, I don't know. According to http://mongoc.org/libmongoc/current/tutorial.html, if it happens, it happens at the end. According to Sure the lookup is possible, now it's just independent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.