Implement FROST share refresh #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseposner
force-pushed
the
frost
branch
4 times, most recently
from
0135f9f
to
cac1662
Compare
wpaulino
force-pushed
the
frost-share-refresh
branch
from
b017f04
to
a8fe0b2
Compare
jesseposner
reviewed
Aug 26, 2024
| ret &= secp256k1_frost_vss_verify_internal(ctx, threshold, id33, &refresh_share_i, &refresh_vss_commitments[i], 1); | ||
|
|
||
| secp256k1_scalar_add(&acc, &acc, &refresh_share_i); | ||
| for (j = 0; j < threshold; j++) { |
There was a problem hiding this comment.
We can perform the point operations more efficiently with secp256k1_ecmult_multi_var.
There was a problem hiding this comment.
Never mind, chatted with @wpaulino, secp256k1_ecmult_multi_var can't be used here because we are doing pairwise addition, not summing the entire vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.