Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Does not check for signer privilege escalation #3

Open
dnut opened this issue Jun 15, 2022 · 1 comment
Open

Does not check for signer privilege escalation #3

dnut opened this issue Jun 15, 2022 · 1 comment

Comments

@dnut
Copy link
Contributor

dnut commented Jun 15, 2022

accounting_invoke in margin escalated the margin account signer permission by setting is_signer to true in the account meta but not actually signing it with invoke_signed. solana_test_validator catches this and fails the ix with "signer privilege escalated" but the simulated runtime doesn't care about it.

in jet_v2 it currently has this bug - it sets the signer to true, but i'm fixing it in the orca branch.

@nevi-me
Copy link
Contributor

nevi-me commented Jun 16, 2022

I couldn't quite figure out what was happening when I did this in another adapter's branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants