-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeID community implementation for Erlang #396
base: main
Are you sure you want to change the base?
Conversation
Adds keysmith, a new TypeID Erlang community implementation. Signed-off-by: Adam Lindberg <[email protected]>
@eproxus Thanks for submitting! Could you point me to the tests validating conformance with the typeid spec? Basically the tests that test these cases: |
@loreto 👍 I'm working on adding those. I'll let you know when it is done. |
@loreto Looking into the test data, it seems the test data does not follow the specification. The specification says:
But the test data contains (among others) the UUID Since my implementation does strict parsing and generation of UUIDs it cannot use this test data for automated tests. |
I realize now that any custom UUID is technically allowed by the spec. I've added validation for the invalid IDs for now, and will work on adding support for validating the valid IDs as well. |
Thanks! Yeah the way I see it is:
|
I've now added support for a more general UUID format so both the valid and invalid test files now pass. You can find the test code here: https://github.com/eproxus/keysmith/blob/main/test/keysmith_tests.erl#L347-L383 |
LGTM |
Summary
Adds keysmith, a new TypeID Erlang community implementation.
How was it tested?
Markdown has been manually reviewed.