Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 and 1.3 are broken, deprecate them #59

Closed
2 tasks done
maelvls opened this issue Jun 24, 2021 · 0 comments
Closed
2 tasks done

1.1 and 1.3 are broken, deprecate them #59

maelvls opened this issue Jun 24, 2021 · 0 comments

Comments

@maelvls
Copy link
Member

maelvls commented Jun 24, 2021

As detailed in GoogleCloudPlatform/marketplace-k8s-app-tools#566, a misplaced field info in the old deployer's Application manifest makes it impossible to install version 1.1 and 1.3 on the Marketplace.

Note that the default version is now 1.4: new users that want to install jetstack-secure-for-cert-manager won't be affected unless they manually select 1.3 or 1.1.

Two options:

  • Either we build and submit two new deployer images (1.1.0-gcm.9 and 1.3.1-gcm.1), but I don't think these versions are going to be installed anyways,

  • Or we "deprecate" 1.1 and 1.3, but the minimum deprecation notice on the Marketplace is 6 months (I tried changing the deprecation date to an earlier date and it would always come back to 14 January 2022):

    For 6 months, users will still be able to select either 1.1 or 1.3 (although being marked as deprecated) and will see their deployment fail with the error:

        error: error validating "/data/resources.yaml": error validating data:
        ValidationError(Application.spec.descriptor): unknown field "info" in
        io.k8s.app.v1beta1.Application.spec.descriptor; if you choose to ignore
        these errors, turn validation off with --validate=false
    

But since I am 99% confident that people won't choose 1.3 or 1.1 (there is no reason to use those versions), I think we can just mark these versions as deprecated and wait for 6 months before they disappear.

I deprecated 1.1 and 1.3 and re-submitted them for review.

I will add a notice:

@maelvls maelvls changed the title Figure out what to do with the broken 1.1 and 1.3 deployers 1.1 and 1.3 are broken, deprecate them Jun 24, 2021
@maelvls maelvls closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant