Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lamb optimizer mistake #443

Open
trofimovaolga opened this issue Jun 24, 2022 · 0 comments
Open

lamb optimizer mistake #443

trofimovaolga opened this issue Jun 24, 2022 · 0 comments

Comments

@trofimovaolga
Copy link

trofimovaolga commented Jun 24, 2022

Hi, I was checking your lamb implementation and I think there is a mistake in it.
According to the paper, exp_avg and exp_avg_sq (m and v) must be updated this way:
m /= (1 - betta_1t)
v /= (1 - betta_2
t)
In your implementation they are not updated and so even if self.debias==True, there is still update missing from adam_norm.
Please correct me if I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant