Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baryon mass incompatible with different unit systems #12

Open
jfields7 opened this issue Aug 4, 2022 · 0 comments
Open

Baryon mass incompatible with different unit systems #12

jfields7 opened this issue Aug 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jfields7
Copy link
Owner

jfields7 commented Aug 4, 2022

The EOSPolicy classes often rely directly on converting between mass density and number density with mb, but mb contains a unit conversion, too. Thus these calculations will be incorrect. It may be simplest for EOS to store a baryon mass in both code units and EOS units, with the latter set by the EOS and the former set by the unit conversion.

@jfields7 jfields7 added the bug Something isn't working label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant