Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different readiness probe pathes for artifactory HA member and primary nodes #1090

Closed
thllxb opened this issue Sep 1, 2020 · 3 comments
Labels
question Further information is requested triaged

Comments

@thllxb
Copy link

thllxb commented Sep 1, 2020

Is this a request for help?:
yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature request

Which chart:
Artifactory HA

What happened:
I cannot specify a different readiness probe to member and primary nodes

What you expected to happen:
I should be able to specify a different readiness probe to member and primary nodes

@chukka chukka added question Further information is requested triaged labels Feb 3, 2021
@chukka
Copy link
Collaborator

chukka commented Dec 14, 2021

@thllxb Can you share more details on this use case

@thllxb
Copy link
Author

thllxb commented Dec 14, 2021

What I mean is, https://github.com/jfrog/charts/blob/master/stable/artifactory-ha/templates/artifactory-primary-statefulset.yaml#L990 and https://github.com/jfrog/charts/blob/master/stable/artifactory-ha/templates/artifactory-node-statefulset.yaml#L875 should be able to be sourced from different configurations to have different values.

In my use case, the primary node can have /artifactory/system/ping to be the liveness prob path, but member nodes needs to have /artifactory/webapp/ to avoid being killed before they are licensed.

@gitta-jfrog
Copy link
Collaborator

Outdated request, Probes were reimplemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested triaged
Projects
None yet
Development

No branches or pull requests

3 participants